Improve testing #60
Merged
Improve testing #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasserahmed10
added
enhancement
|
❌ Test or Coverage checks failed! Please check the workflow run for details. |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2024.3.4
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the CSV parsing logic, enhancements to existing repository tests, and the addition of new test cases for
AuditLogRepositoryImpl,ProjectsRepositoryImpl, andTaskRepositoryImpl. The most important changes are grouped below by theme.CSV Parsing Enhancements:
UserCsvParserto handle cases where the number of fields in a line might exceed the expected limit. Thesplitmethod now uses a limit of 6, and additional checks ensure safe access to optional fields likeprojectIdsandtaskIds.toStringListextension function to trim strings before processing, ensuring cleaner data parsing.Test Additions for Repositories:
getAllLogsByTaskIdandgetAllLogsByProjectId, ensuring proper delegation to the data source and validation of returned data.addProject,updateProject,deleteProject, andgetAllProjectsByUser, including validation of admin privilege checks and exception handling for edge cases.